Skip to content

refactor: establish Workers folder feature - #335

Open
jderochervlk wants to merge 2 commits into
codex/option5-storage-folderfrom
codex/option5-workers-folder
Open

refactor: establish Workers folder feature#335
jderochervlk wants to merge 2 commits into
codex/option5-storage-folderfrom
codex/option5-workers-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 25 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #334.

Summary

  • add the target src/workers folder on the unqualified internal Workers feature
  • consolidate Web Worker and Service Worker interfaces
  • add the supported WebAPI.Workers -> WebAPI.Messaging + WebAPI.Storage + Workers feature
  • preserve all existing flat worker and service-worker module paths
  • remove the transitional old WebAPI.ServiceWorker and WebAPI.WebWorkers source features

Boundary note

Cache and CacheStorage remain in Storage from the previous PR. Workers receives their types through WebAPI.Storage, while WebAPI.Messaging supplies MessagePort, MessageEvent, push, and notification-related dependencies.

Temporary state

  • the mixed WebWorkersTypes support module remains in Storage until final helper cleanup; worker interfaces consume it transitively through the declared Storage dependency
  • Navigator.serviceWorker remains in the legacy Navigator interface until the next layer
  • final feature-graph guardrails and cleanup remain deferred until the stack is complete

Review focus

  • Workers domain membership
  • the Messaging/Storage dependency closure
  • resolution of the previous PR's transitional source features

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,File,URL,Fetch,Storage,Messaging,Workers
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: c326336906

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch 2 times, most recently from bd520ee to a07dbb1 Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch 2 times, most recently from 6ecf2ab to 493c336 Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch from 493c336 to 27fd435 Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch from 27fd435 to 4949aa5 Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch from 4949aa5 to 475f6db Compare August 5, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch from 475f6db to 7ab721a Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch from 7ab721a to 49f71a7 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch from 49f71a7 to 2b83bc7 Compare August 5, 2026 15:09
@jderochervlk
jderochervlk force-pushed the codex/option5-workers-folder branch from 2b83bc7 to a0fa4a6 Compare August 5, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant